Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting new sequence by typing in sequence mode #5136

Closed
ljubica-milovic opened this issue Jul 19, 2024 · 2 comments · Fixed by #5173
Closed

Starting new sequence by typing in sequence mode #5136

ljubica-milovic opened this issue Jul 19, 2024 · 2 comments · Fixed by #5173
Assignees
@rrodionov91
Labels
feature request Sequence mode Bucket: Sequence mode related issues Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.24.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jul 19, 2024 •
edited by rrodionov91
Loading

Background
Currently, if the user is in "view only" mode in sequence mode and types something on the keyboard, nothing happens.
To make starting a new sequence for the user easier, the ability to enter "text editing" mode via typing from keyboard should be added.

Requirements

  1. If the canvas is empty (there are no sequences on the canvas), and the user types an appropriate symbol from the keyboard that should result in adding the monomer represented by that symbol as the first (and only) monomer in the sequence, turning on "text edit" mode and placing of the caret after the first monomer. (same logic for requirement 5 from issue #4878).
  2. If RNA is selected as a type of sequence,
    image
    appropriate symbols are: A, C, G, U, T
  3. If DNA is selected as a type of sequence, appropriate symbols are: A, C, G, U, T
  4. If Peptide is selected as a type of sequence, appropriate symbols are: A, C, D, E, F, G, H, I, K, L, M, N, P, Q, R, S, T, V, W, Y

Monomers that are represented by appropriate letters are covered by #1426
@ljubica-milovic ljubica-milovic added the Sequence mode Bucket: Sequence mode related issues label Jul 19, 2024
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Jul 22, 2024
@rrodionov91 rrodionov91 self-assigned this Jul 24, 2024
rrodionov91 added a commit that referenced this issue Jul 25, 2024
@rrodionov91
#4887 - Starting new sequences with "Plus" icon on canvas
de948eb 
#5136 - Starting new sequence by typing in sequence mode
@rrodionov91 rrodionov91 mentioned this issue Jul 25, 2024
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 29, 2024
@rrodionov91
#4887 - Starting new sequences with "Plus" icon on canvas
de38d91 
#5136 - Starting new sequence by typing in sequence mode
rrodionov91 added a commit that referenced this issue Jul 29, 2024
@rrodionov91
#4887 - Starting new sequences with "Plus" icon on canvas (#5173)
93f7b05 
* #4887 - Starting new sequences with "Plus" icon on canvas
* #5136 - Starting new sequence by typing in sequence mode

- added enabling edit mode by entering symbol on empty canvas
- added blinking cell on empty canvas
- reworked selection for sequence items
- added buttons for new sequences between lines
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.2.1-gd93b8ec4-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

@Zhirnoff Zhirnoff mentioned this issue Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
feature request Sequence mode Bucket: Sequence mode related issues Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.24.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4887 - Starting new sequences with "Plus" icon on canvas epam/ketcher
3 participants
@rrodionov91 @AlexeyGirin @ljubica-milovic