Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: Update Image object in KET file to support CDX/CDXML format #5172

Closed
yauhen-karmyzau opened this issue Jul 25, 2024 · 2 comments · Fixed by #5188
Closed

Preview: Update Image object in KET file to support CDX/CDXML format #5172

yauhen-karmyzau opened this issue Jul 25, 2024 · 2 comments · Fixed by #5188
Assignees
Labels
Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Test Cases Written Test cases has been written for that issue

Comments

@yauhen-karmyzau
Copy link
Collaborator

yauhen-karmyzau commented Jul 25, 2024

"type": "image",
"format": "image MIME type",
"boundingBox": {
"x": x, "y": y, // left top
"z": z, // optional z
"width": WIDTH,
"height": HEIGHT
},
"data": "base64-encoded-string"

images.zip

@yauhen-karmyzau yauhen-karmyzau added Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Jul 25, 2024
@ivanmaslow ivanmaslow added the Test Cases Written Test cases has been written for that issue label Jul 26, 2024
daniil-sloboda added a commit that referenced this issue Jul 29, 2024
daniil-sloboda added a commit that referenced this issue Jul 29, 2024
daniil-sloboda added a commit that referenced this issue Aug 1, 2024
daniil-sloboda added a commit that referenced this issue Aug 1, 2024
daniil-sloboda added a commit that referenced this issue Aug 2, 2024
@ivanmaslow
Copy link
Collaborator

Preview exploratory testing is completed on env with 5172-update-ket-image branch:

  • Ketcher version: [Version 2.23.0-rc.3] Build at 2024-08-01; 08:58:34
  • Indigo version: Version 1.23.0-dev.4.0-gb71e441d7-wasm32-wasm-clang-19.0.0
    Points below are covered:
  • Json structure for images in .ket file was changed (example for .svg):

{
"root": {
"nodes": [
{
"type": "image",
"format": "image/svg+xml",
"boundingBox": {
"x": 18.424999999999997,
"y": -9.774999999999997,
"z": 0,
"width": 4.900000000000002,
"height": 4.775000000000006
},
"data": "PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz48IS0tIFVwbG9hZGVkIHRvOiBTVkcgUmVwbywgd3d3LnN2Z3JlcG8uY29tLCBHZW5lcmF0b3I6IFNWRyBSZXBvIE1peGVyIFRvb2xzIC0tPg0KPHN2ZyB3aWR0aD0iODAwcHgiIGhlaWdodD0iODAwcHgiIHZpZXdCb3g9IjAgMCAyNCAyNCIgZmlsbD0ibm9uZSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4NCjxwYXRoIGQ9Ik0zIDEzLjY0OTNDMyAxNi42MDQ0IDUuNDE3NjYgMTkgOC40IDE5TDE2LjUgMTlDMTguOTg1MyAxOSAyMSAxNi45ODM5IDIxIDE0LjQ5NjlDMjEgMTIuNjUwMyAxOS44ODkzIDEwLjk0NDkgMTguMyAxMC4yNUMxOC4xMzE3IDcuMzIyNTEgMTUuNjg0IDUgMTIuNjg5MyA1QzEwLjM1MTQgNSA4LjM0Njk0IDYuNDg2MzcgNy41IDguNUM0LjggOC45Mzc1IDMgMTEuMjAwMSAzIDEzLjY0OTNaIiBzdHJva2U9IiMwMDAwMDAiIHN0cm9rZS13aWR0aD0iMiIgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIiBzdHJva2UtbGluZWpvaW49InJvdW5kIi8+DQo8L3N2Zz4="
}
],
"connections": [],
"templates": []
}
}

daniil-sloboda added a commit that referenced this issue Aug 5, 2024
rrodionov91 pushed a commit that referenced this issue Aug 5, 2024
…5188)

* #5172 - updated ket image format

* #5172 - fixed failing types

* #5172 - fixed regex

* #5172 - fixed package-lock file

* #5172 - updated file mime regexp
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Aug 9, 2024

Tested.

2024-08-09_11h46_19

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.24.0-rc.1]
Indigo version
[Version 1.23.0-rc.1]

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
…5188)

* #5172 - updated ket image format

* #5172 - fixed failing types

* #5172 - fixed regex

* #5172 - fixed package-lock file

* #5172 - updated file mime regexp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Test Cases Written Test cases has been written for that issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants