Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select/Edit Connection Points" dialogues for ambiguous monomers #5224

Closed
ljubica-milovic opened this issue Aug 6, 2024 · 2 comments · Fixed by #5412
Closed

"Select/Edit Connection Points" dialogues for ambiguous monomers #5224

ljubica-milovic opened this issue Aug 6, 2024 · 2 comments · Fixed by #5412
Assignees

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Aug 6, 2024

Background
Ambiguous monomers will have the functionality of any other monomer on canvas, thus "Select Connection Points" and "Edit Connection Points" dialogues will need to be opened sometimes.
Because ambiguous monomers do not have a structure as such, a new UX for these dialogues is needed.

Requirements

  1. If an ambiguous monomer has a type, instead of a monomer name there should be "Ambiguous [type]"

All monomers that make up the ambiguous monomer are amino acids -> The ambiguous monomer is an amino acid -> The "name" should be "Ambiguous Amino Acid"

  1. If a ambiguous monomer has no type, instead of a monomer name there should be "Ambiguous Monomer"

Ambiguous monomer is made up from one amino acid and one CHEM -> The ambiguous monomer has no type -> The "name" should be "Ambiguous Monomer"

Type Text instead of monomer name
CHEM Ambiguous CHEM
Sugar Ambiguous Sugar
Base Ambiguous Base
Phosphate Ambiguous Phosphate
Nucleotide Ambiguous Nucleotide
Amino acid Ambiguous Amino Acid
None Ambiguous Monomer
  1. A ambiguous monomer has an attachments point Rn only of all the monomers have attachment point Rn (as described in related issue #4554).
    3.1. If all monomers that make up the ambiguous monomer have the same atom as a leaving group for the attachment point Rn, then those atoms should be displayed bellow the Rn button.
    3.2. If at least one monomer that makes up the ambiguous monomer has a different atom as a leaving group for the attachment point Rn, the space bellow the Rn button should be empty.

  2. Instead of the structure, the representation of that ambiguous monomer on canvas should be shown (see mockups).

  3. All the other functionality of "Select Connection Points" and "Edit Connection Points" dialogues remains unchanged.

UX
image

@AlexeyGirin
Copy link
Collaborator

Test cases added

@svvald svvald self-assigned this Aug 23, 2024
@ljubica-milovic ljubica-milovic changed the title "Select/Edit Connection Points" dialogues for variant monomers "Select/Edit Connection Points" dialogues for ambiguous monomers Aug 26, 2024
svvald added a commit that referenced this issue Sep 2, 2024
svvald added a commit that referenced this issue Sep 2, 2024
svvald added a commit that referenced this issue Sep 3, 2024
svvald added a commit that referenced this issue Sep 3, 2024
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Sep 9, 2024

Tested.
2024-09-09_17h26_17
2024-09-09_17h26_40

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.1]
Indigo version
[Version 1.24.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants