Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace phosphate at the end with petide causes cycled polymer #5242

Closed
AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5259 or #5271
Closed

Replace phosphate at the end with petide causes cycled polymer #5242

AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5259 or #5271
Assignees
@rrodionov91
Labels
Monomer Library Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.24.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Aug 8, 2024 •
edited
Loading

NOTE: Widely spread problem with all types of monomers

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Load from file: Replace phosphate at the end with petide causes cycled polymer.zip
    image
  3. Select last to symbols and click on C monomer from Peptide tab at Library
    image

Actual behavior
System made a cycled chain (What? Yes!)
image

Expected behavior
Phosphate at the end replaced with C peptide
image

As per requirement:

  1. If the user selects any number of monomers in view mode, and clicks on the monomer card in the library, all selected monomer on the canvas are replaced by chosen monomer from the library each

Versions

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Related issue - #4878
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.24.0-rc.2 milestone Aug 8, 2024
@rrodionov91 rrodionov91 self-assigned this Aug 8, 2024
rrodionov91 added a commit that referenced this issue Aug 8, 2024
@rrodionov91
#5242 - Replace phosphate at the end with petide causes cycled polymer
997ff4d 
- changed usage of previous/next node to previous/next node in same chain for replacing sequence items through the library
@rrodionov91 rrodionov91 linked a pull request Aug 8, 2024 that will close this issue
Backmerge: #5242 - Replace phosphate at the end with petide causes cycled polymer #5259
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 9, 2024
@rrodionov91
#5242 - Replace phosphate at the end with petide causes cycled polymer
45b31c1 
- changed usage of previous/next node to previous/next node in same chain for replacing sequence items through the library
rrodionov91 added a commit that referenced this issue Aug 9, 2024
@rrodionov91
#5242 - Replace phosphate at the end with petide causes cycled polymer (
f87ac65 
#5271)

- changed usage of previous/next node to previous/next node in same chain for replacing sequence items through the library
- fixed replacement of single selection of two chains
@rrodionov91 rrodionov91 linked a pull request Aug 9, 2024 that will close this issue
#5242 - Replace phosphate at the end with petide causes cycled polymer #5271
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 9, 2024
@rrodionov91
Backmerge: #5242 - Replace phosphate at the end with petide causes cy…
5506be9 
…cled polymer (#5259)

- changed usage of previous/next node to previous/next node in same chain for replacing sequence items through the library
- fixed replacement of single selection of two chains
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5242 - Replace phosphate at the end with petide causes cy…
ffffb5d 
…cled polymer (#5259)

- changed usage of previous/next node to previous/next node in same chain for replacing sequence items through the library
- fixed replacement of single selection of two chains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Monomer Library Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.24.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin