Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of peptide at the end of sequence on preset w/out phosphate works wrong #5243

Closed
AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5278 or #5274
Closed
Assignees
Labels

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Load from file: Replacement of peptide at the end on preset w_out phosphate works wrong.zip
    image
  3. Create custom preset without phosphate and name it "No phosphate"
    image
  4. Select last monomer (in view mode)
    image
  5. Click on "No phosphate" preset in the library

Actual behavior
"Confirm Your Actions" dialog appears
image
Click YES
System replace A peptide with C preset and make cycled polymer
image

Expected behavior
No dialog appears
System replace A peptide with C preset
image

As per requirement:

  1. If the user selects any number of monomers in view mode, and clicks on the monomer card in the library, all selected monomer on the canvas are replaced by chosen monomer from the library each

Versions

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Related issue - #4878

@AlexeyGirin AlexeyGirin added this to the Ketcher 2.24.0-rc.2 milestone Aug 8, 2024
@AlexeyGirin AlexeyGirin changed the title Replacement of peptide at the end on preset w/out phosphate works wrong Replacement of peptide at the end of sequence on preset w/out phosphate works wrong Aug 8, 2024
@rrodionov91 rrodionov91 self-assigned this Aug 14, 2024
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment