Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5245 - Replacement of peptide at the end of sequence on preset w/out base works wrong #5274

Merged
merged 2 commits into from
Aug 12, 2024
Merged

#5245 - Replacement of peptide at the end of sequence on preset w/out base works wrong #5274

merged 2 commits into from
Aug 12, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Aug 9, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

  • moved rna node addition in sequence mode to separate function
  • removed restriction of insertion/replacing rna without base

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91
#5245 - Replacement of peptide at the end of sequence on preset w/out…
b2ba743 
… base works wrong

- moved rna node addition in sequence mode to separate function
- removed restriction of insertion/replacing rna without base
@rrodionov91 rrodionov91 linked an issue Aug 9, 2024 that may be closed by this pull request
Replacement of peptide at the end of sequence on preset w/out base works wrong #5245
Closed
@rrodionov91 rrodionov91 merged commit 92efa93 into release/2.24 Aug 12, 2024
3 checks passed
@rrodionov91 rrodionov91 deleted the 5245-replace-to-rna-without-base branch August 12, 2024 10:35
This was linked to issues Aug 14, 2024
Unable to put preset w/out base on the sequence mode canvas from the library #5239
Closed
Replacement of peptide at the end of sequence on preset w/out phosphate works wrong #5243
Closed
Replacement of preset at the end of sequence on preset w/out base works wrong #5248
Closed
Replacement of peptide at the end of sequence on base (C) rises unnessessury error message #5246
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svvald svvald svvald approved these changes

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rrodionov91 @svvald