Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement of peptide at the end of sequence on preset w/out base works wrong #5245

Closed
AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5274 or #5278
Closed

Replacement of peptide at the end of sequence on preset w/out base works wrong #5245

AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5274 or #5278
Assignees
@rrodionov91
Labels
bug Monomer Library Priority: High
Milestone
Ketcher 2.24.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Aug 8, 2024 •
edited by rrodionov91
Loading

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Load from file: Replacement of peptide at the end on preset w_out phosphate works wrong.zip
    image
  3. Create custom preset without base and name it "No base"
    image
  4. Select last monomer (in view mode)
    image
  5. Click on "No base" preset in the library

Actual behavior
"Confirm Your Actions" dialog appears
image
Click YES
System removes last peptide from the sequence
image

Expected behavior
No dialog appears
System replace A peptide with @ symbol
image

As per requirement:

  1. If the user selects any number of monomers in view mode, and clicks on the monomer card in the library, all selected monomer on the canvas are replaced by chosen monomer from the library each

Versions

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Related issue - #4878
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.24.0-rc.2 milestone Aug 8, 2024
@rrodionov91 rrodionov91 self-assigned this Aug 9, 2024
rrodionov91 added a commit that referenced this issue Aug 9, 2024
@rrodionov91
#5245 - Replacement of peptide at the end of sequence on preset w/out…
b2ba743 
… base works wrong

- moved rna node addition in sequence mode to separate function
- removed restriction of insertion/replacing rna without base
@rrodionov91 rrodionov91 linked a pull request Aug 9, 2024 that will close this issue
#5245 - Replacement of peptide at the end of sequence on preset w/out base works wrong #5274
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 12, 2024
@rrodionov91
#5245 - Replacement of peptide at the end of sequence on preset w/out…
92efa93 
… base works wrong (#5274)

- moved rna node addition in sequence mode to separate function
- removed restriction of insertion/replacing rna without base
- fixed conditions sequence in rna addition method for sequence mode
rrodionov91 added a commit that referenced this issue Aug 12, 2024
@rrodionov91
#5245 - Replacement of peptide at the end of sequence on preset w/out…
965740a 
… base works wrong

- moved rna node addition in sequence mode to separate function
- removed restriction of insertion/replacing rna without base
@rrodionov91 rrodionov91 linked a pull request Aug 12, 2024 that will close this issue
Backmerge: #5245 - Replacement of peptide at the end of sequence on preset w/out base works wrong #5278
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 12, 2024
@rrodionov91
Backmerge: #5245 - Replacement of peptide at the end of sequence on p…
6b6546e 
…reset w/out base works wrong (#5278)

- moved rna node addition in sequence mode to separate function
- removed restriction of insertion/replacing rna without base
- fixed conditions sequence in rna addition method for sequence mode
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.

2024-08-15_14h13_21.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 127.0.6533.120 (Official Build) (64-bit)

Ketcher version
[Version 2.24.0-rc.2]
Indigo version
[Version 1.23.0-rc.2]

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5245 - Replacement of peptide at the end of sequence on p…
481e475 
…reset w/out base works wrong (#5278)

- moved rna node addition in sequence mode to separate function
- removed restriction of insertion/replacing rna without base
- fixed conditions sequence in rna addition method for sequence mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Monomer Library Priority: High
Projects
None yet
Milestone
Ketcher 2.24.0-rc.2
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff