Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHEMs to the library #5244

Closed
ljubica-milovic opened this issue Aug 8, 2024 · 4 comments · Fixed by #5291
Closed

Add CHEMs to the library #5244

ljubica-milovic opened this issue Aug 8, 2024 · 4 comments · Fixed by #5291
Assignees
@KristinaKasyanovskaya
Labels
feature request Monomer Library Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.25.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

Name Symbol Structure Leaving group (attachment atom-leaving group atom)
Biotin B7 Biotin.zip R1=OH (15-16)
P-quinoid fluorescein flsQ P-quinoid fluorescein.zip R1=H (16-25)
Lactone fluorescein flsL Lactone fluorescein.zip R1=H (19-25)

image
image
image
@AlexeyGirin
Copy link
Collaborator

No test cases needed for that particular case

@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Aug 13, 2024
@KristinaKasyanovskaya KristinaKasyanovskaya self-assigned this Aug 13, 2024
Merged
10 tasks
@KristinaKasyanovskaya KristinaKasyanovskaya linked a pull request Aug 14, 2024 that will close this issue
#5244 - Add CHEMs to the library #5291
Merged
10 tasks
svvald pushed a commit that referenced this issue Aug 20, 2024
@KristinaKasyanovskaya
#5244 - Add CHEMs to the library (#5291)
d1ba56d 
* feat: add chems to the library

* update test

* update test

* feat: change attachment point structure and formatting file

* refactor: shortened keys and id properties for CHEMs based on alias and fullName structure
@AlexeyGirin
Copy link
Collaborator

Verified.
@KristinaKasyanovskaya to change P-quinonoid fluorescein to P-quinoid fluorescein

Ketcher Version 2.24.0-rc.1 Build at 2024-08-26; 05:32:17
Indigo Toolkit Version 1.24.0-dev.4.0-ga81491ac-wasm32-wasm-clang-12.0.0
Chrome Version 127.0.6533.100 (Official Build) (64-bit)
Win10

Merged
9 tasks
@KristinaKasyanovskaya
Copy link
Collaborator

change P-quinonoid fluorescein to P-quinoid fluorescein

Fixed => #5384

This was referenced Aug 30, 2024
Closed
Closed
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Sep 6, 2024

Tested.
2024-09-06_15h12_36
2024-09-06_15h12_43
2024-09-06_15h12_48

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.1]
Indigo version
[Version 1.24.0-rc.1]

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@KristinaKasyanovskaya @Guch1g0v
#5244 - Add CHEMs to the library (#5291)
3153fc1 
* feat: add chems to the library

* update test

* update test

* feat: change attachment point structure and formatting file

* refactor: shortened keys and id properties for CHEMs based on alias and fullName structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristinaKasyanovskaya KristinaKasyanovskaya

Labels
feature request Monomer Library Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.25.0-rc.1
Development

Successfully merging a pull request may close this issue.

#5244 - Add CHEMs to the library epam/ketcher
4 participants
@AlexeyGirin @Zhirnoff @ljubica-milovic @KristinaKasyanovskaya