Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New preset creation process intefere with monomer replacement on the sequence mode #5255

Closed
AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5260
Closed

New preset creation process intefere with monomer replacement on the sequence mode #5255

AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5260
Assignees
@svvald
Labels
bug Priority: High RNA Builder Bucket: RNA builder related issues Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.24.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Aug 8, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Go to Library and click New preset
  3. Go to Sugar section and click any sugar (R - in my cases)

Actual behavior
Clicked sugar appeared on the canvas and in RNA builder
image

Expected behavior
Canvas remains blank, clicked sugar appeared at RNA builder only
image

Versions

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Related issue - #4878
@AlexeyGirin AlexeyGirin added bug Priority: High RNA Builder Bucket: RNA builder related issues Sequence mode Bucket: Sequence mode related issues labels Aug 8, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.24.0-rc.2 milestone Aug 8, 2024
@svvald svvald self-assigned this Aug 8, 2024
svvald added a commit that referenced this issue Aug 8, 2024
@svvald
#5255 – Fix adding new monomers to canvas in sequence mode while edit…
e73f342 
…ing RNA in builder
svvald added a commit that referenced this issue Aug 8, 2024
@svvald
Backmerge: #5255 – Fix adding new monomers to canvas in sequence mode…
74509c8 
… while editing RNA in builder
@svvald svvald linked a pull request Aug 8, 2024 that will close this issue
Backmerge: #5255 – Fix adding new monomers to canvas in sequence modewhile editing RNA in builder #5260
Merged
9 tasks
svvald added a commit that referenced this issue Aug 8, 2024
@svvald
#5255 – Fix adding new monomers to canvas in sequence mode while edit…
4a716f9 
…ing RNA in builder
svvald added a commit that referenced this issue Aug 9, 2024
@svvald
#5255 – Fix adding new monomers to canvas in sequence mode while edit…
74ddccd 
…ing RNA in builder (#5261)

* #5255 – Fix adding new monomers to canvas in sequence mode while editing RNA in builder

* #5261 – Add hook mock to unit test
svvald added a commit that referenced this issue Aug 9, 2024
@svvald
Backmerge: #5255 – Fix adding new monomers to canvas in sequence mode…
bfbffa7 
… while editing RNA in builder
svvald added a commit that referenced this issue Aug 11, 2024
@svvald
Backmerge: #5255 – Fix adding new monomers to canvas in sequence mode…
2b898c6 
… while editing RNA in builder (#5260)
@AlexeyGirin
Copy link
Collaborator Author

That particular case has fixed. Follow up bug has been created: #5301

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@svvald @Guch1g0v
Backmerge: #5255 – Fix adding new monomers to canvas in sequence mode…
8e55feb 
… while editing RNA in builder (#5260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svvald svvald

Labels
bug Priority: High RNA Builder Bucket: RNA builder related issues Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.24.0-rc.2
2 participants
@svvald @AlexeyGirin