Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The application crashes when selecting Enhanced Stereochemistry from the right-click menu #5335

Closed
Zhirnoff opened this issue Aug 21, 2024 · 2 comments · Fixed by #5342, #5348 or #5349
Closed

The application crashes when selecting Enhanced Stereochemistry from the right-click menu #5335

Zhirnoff opened this issue Aug 21, 2024 · 2 comments · Fixed by #5342, #5348 or #5349
Assignees
@rrodionov91
Labels
bug Priority: High Stereochemistry User's Feedback
Milestone
Ketcher 2.23.0-rc.5

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open DevTool Console and paste use ketcher.setMolecule attached file a.json.zip
  2. Right-click on atom with stereo bond and select 'Enchanced stereochemistry'

Actual behavior
The application crashes when selecting Enhanced Stereochemistry from the right-click menu
It seems this happens because the original file lacks the "stereoLabel": "abs" field.
2024-08-21_15h30_05

Expected behavior
The window for selecting Enhanced Stereochemistry appears.

Screenshots

2024-08-21_15h57_00.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 127.0.6533.120 (Official Build) (64-bit)

Ketcher version
[Version 2.24.0-rc.3]
Indigo version
[Version 1.23.0-rc.2]

#188080437
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Aug 21, 2024 •
edited by rrodionov91
Loading

Moved to Ketcher 2.23.0-rc.5.

@rrodionov91 rrodionov91 self-assigned this Aug 22, 2024
rrodionov91 added a commit that referenced this issue Aug 22, 2024
@rrodionov91
#5335 - The application crashes when selecting Enhanced Stereochemist…
4b8617e 
…ry from the right-click menu

- added set stereo labels to atoms to setMolecule
@rrodionov91 rrodionov91 linked a pull request Aug 22, 2024 that will close this issue
#5335 - The application crashes when selecting Enhanced Stereochemistry from the right-click menu #5342
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 22, 2024
@rrodionov91
#5335 - The application crashes when selecting Enhanced Stereochemist…
184246d 
…ry from the right-click menu (#5342)

- added set stereo labels to atoms to setMolecule
rrodionov91 added a commit that referenced this issue Aug 22, 2024
@rrodionov91
#5335 - The application crashes when selecting Enhanced Stereochemist…
99da219 
…ry from the right-click menu (#5342)

- added set stereo labels to atoms to setMolecule
rrodionov91 added a commit that referenced this issue Aug 22, 2024
@rrodionov91
#5335 - The application crashes when selecting Enhanced Stereochemist…
678819f 
…ry from the right-click menu (#5342)

- added set stereo labels to atoms to setMolecule
This was linked to pull requests Aug 22, 2024
Backmerge: #5335 - The application crashes when selecting Enhanced Stereochemistry from the right-click menu #5348
Merged
Backmerge: #5335 - The application crashes when selecting Enhanced Stereochemistry from the right-click menu #5349
Merged
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.

2024-08-22_20h09_17.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 127.0.6533.120 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.5]
Indigo version
[Version 1.22.0-rc.3]

rrodionov91 added a commit that referenced this issue Aug 23, 2024
@rrodionov91
#5335 - The application crashes when selecting Enhanced Stereochemist…
b5a9b01 
…ry from the right-click menu (#5342) (#5348)

- added set stereo labels to atoms to setMolecule
rrodionov91 added a commit that referenced this issue Aug 26, 2024
@rrodionov91
Backmerge: #5335 - The application crashes when selecting Enhanced St…
06bf272 
…ereochemistry from the right-click menu (#5349)

- added set stereo labels to atoms to setMolecule
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5335 - The application crashes when selecting Enhanced St…
52066d1 
…ereochemistry from the right-click menu (#5349)

- added set stereo labels to atoms to setMolecule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High Stereochemistry User's Feedback
Projects
None yet
Milestone
Ketcher 2.23.0-rc.5
2 participants
@rrodionov91 @Zhirnoff