Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview tooltip for mixture ambiguous monomer shows wrong percentages #5427

Closed
AlexeyGirin opened this issue Sep 4, 2024 · 1 comment · Fixed by #5459 or #5484
Closed

Preview tooltip for mixture ambiguous monomer shows wrong percentages #5427

AlexeyGirin opened this issue Sep 4, 2024 · 1 comment · Fixed by #5459 or #5484
Assignees
@rrodionov91
Labels
bug Flex mode Bucket: Flex canvas related mode HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Milestone
Ketcher 2.25.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Sep 4, 2024 •
edited
Loading

Steps to Reproduce

  1. Toggle to Macro - Flex
  2. Load from clipboard way: PEPTIDE1{(D:5+N:4+I)}$$$$V2.0
  3. Hover mouse over monomer

Actual behavior
Preview tooltip for mixture ambiguous monomer shows wrong percentages
image

Expected behavior
Percentages should be:
50% - Aspartic acid
40% - Asparagine
10% - Isoleucine

Unknown quantity for Isoleucine should be considered as 1 (as per @ljubica-milovic decision)

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Reference issues: #4555
@AlexeyGirin AlexeyGirin added bug Priority: Medium Flex mode Bucket: Flex canvas related mode HELM Bucket: Bugs related to Export to HELM format labels Sep 4, 2024
@rrodionov91 rrodionov91 self-assigned this Sep 9, 2024
rrodionov91 added a commit that referenced this issue Sep 9, 2024
@rrodionov91
#5427 - Preview tooltip for mixture ambiguous monomer shows wrong per…
12f774b 
…centages
rrodionov91 added a commit that referenced this issue Sep 9, 2024
@rrodionov91
#5427 - Preview tooltip for mixture ambiguous monomer shows wrong per…
89633d0 
…centages
This was linked to pull requests Sep 9, 2024
#5427 - Preview tooltip for mixture ambiguous monomer shows wrong percentages #5457
Closed
#5427 - Preview tooltip for mixture ambiguous monomer shows wrong percentages #5459
Merged
rrodionov91 added a commit that referenced this issue Sep 10, 2024
@rrodionov91
#5427 - Preview tooltip for mixture ambiguous monomer shows wrong per…
d945a3f 
…centages (#5459)
rrodionov91 added a commit that referenced this issue Sep 10, 2024
@rrodionov91
#5427 - Preview tooltip for mixture ambiguous monomer shows wrong per…
465ae95 
…centages
@rrodionov91 rrodionov91 linked a pull request Sep 10, 2024 that will close this issue
Backmerge: #5427 - Preview tooltip for mixture ambiguous monomer shows wrong percentages #5484
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 11, 2024
@rrodionov91
#5427 - Preview tooltip for mixture ambiguous monomer shows wrong per…
cf5c80e 
…centages (#5484)
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image
Versions

  • Ketcher Version 2.25.0-rc.2 Build at 2024-09-14; 10:47:47
  • Indigo Toolkit Version 1.24.0-rc.2.0-g5f2751d70-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.138 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#5427 - Preview tooltip for mixture ambiguous monomer shows wrong per…
f8ecbbd 
…centages (#5484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Flex mode Bucket: Flex canvas related mode HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Projects
None yet
Milestone
Ketcher 2.25.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin