Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change bond length for ACS styles settings #5435

Closed
AlexanderSavelyev opened this issue Sep 5, 2024 · 0 comments · Fixed by #5524
Closed

Change bond length for ACS styles settings #5435

AlexanderSavelyev opened this issue Sep 5, 2024 · 0 comments · Fixed by #5524
Assignees
@accmeboot
Labels
phase III Team G

Comments

@AlexanderSavelyev
Copy link
Contributor

Background
Bond length is not changed visually on canvas

Solution
Bond length should be changed according to the specified value and unit. The image resolution should be taken as default

Additional information
1 inch = 72 pt
1 inch = 2.54 cm
length in pixels = ppi * length in inch
@AlexanderSavelyev AlexanderSavelyev changed the title Change bond length for according ACS styles settings Change bond length for ACS styles settings Sep 5, 2024
@AnnaKosol AnnaKosol mentioned this issue Aug 29, 2024
Closed
@accmeboot accmeboot self-assigned this Sep 13, 2024
accmeboot pushed a commit that referenced this issue Sep 13, 2024
#5435 - added scale factor to reflect the bond length on the canvas
a54a414
@accmeboot accmeboot linked a pull request Sep 17, 2024 that will close this issue
#5435 - Change bond length for ACS styles settings #5524
Merged
9 tasks
accmeboot pushed a commit that referenced this issue Sep 17, 2024
#5435 - autotests update & bondLength convertion's condition fix
25e20a7
rrodionov91 pushed a commit that referenced this issue Sep 19, 2024
@accmeboot
#5435 - Change bond length for ACS styles settings (#5524)
ae7591f 
- added scale factor to reflect the bond length on the canvas
- autotests update & bondLength convertion's condition fix

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@accmeboot @Guch1g0v
#5435 - Change bond length for ACS styles settings (#5524)
e83be36 
- added scale factor to reflect the bond length on the canvas
- autotests update & bondLength convertion's condition fix

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@accmeboot accmeboot

Labels
phase III Team G
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#5435 - Change bond length for ACS styles settings epam/ketcher
4 participants
@AlexanderSavelyev @accmeboot @AnnaKosol @AlekseiKhariukov