Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with loading from KET Multi-Tailed arrows because of floating-point format of coordinates #5447

Closed
ivanmaslow opened this issue Sep 6, 2024 · 3 comments · Fixed by #5450 or #5494
Assignees
Labels
bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Priority: High

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Sep 6, 2024

Steps to Reproduce

  1. Open in Ketcher one of valid .ket files (6 different cases) with saved Multi-Tailed Arrows:
    Zip.zip

Actual behavior

  • Error message is displayed
    image

Expected behavior

  • No errors, elements from .ket file are displayed on Canvas
    TBD - fixed-point precision (4 decimal places)?

Environment Details

  • Ketcher [Version 2.25.0-rc.1] Build at 2024-09-03; 15:31:03
  • Indigo Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Windows 11 Enterprise
  • Chrome Version 128.0.6613.120 (Official Build) (64-bit)

Additional context

@ivanmaslow ivanmaslow added this to the Ketcher 2.25.0-rc.2 milestone Sep 6, 2024
@ivanmaslow ivanmaslow added the MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes label Sep 6, 2024
daniil-sloboda added a commit that referenced this issue Sep 8, 2024
@ivanmaslow
Copy link
Collaborator Author

Tested on nightly environment (5447-fixed-precision), the issue with floating point is fixed, files below can be loaded without issues:
Floating Point Issues.zip

But the logic of movement tails is broken - the user can move tails closer than 0.35 to each other:
Image

daniil-sloboda added a commit that referenced this issue Sep 9, 2024
@ivanmaslow
Copy link
Collaborator Author

ivanmaslow commented Sep 10, 2024

Retested on nightly environment (5447-fixed-precision), the issue with floating point is fixed (fixed-point precision = 5 decimal places, files below can be loaded without issues:
Floating Point Issues.zip
Issue with movement of tails is fixed, user can't move tails closer than 0.35 to each other:
image

rrodionov91 pushed a commit that referenced this issue Sep 10, 2024
…ith fixed precision usage (#5450)

- fixed tails movement
rrodionov91 pushed a commit that referenced this issue Sep 11, 2024
…ith fixed precision usage (#5450)

- fixed tails movement

(cherry picked from commit 589624b)
rrodionov91 added a commit that referenced this issue Sep 12, 2024
…ith fixed precision usage (#5450)

- fixed tails movement

Co-authored-by: Daniil Sloboda <daniil_sloboda@epam.com>
@ivanmaslow
Copy link
Collaborator Author

Tested on Remote RC environment:

  • Ketcher [Version 2.25.0-rc.2] Build at 2024-09-14; 10:54:23
  • Indigo Version 1.24.0-rc.2.0-g5f2751d70-x86_64-linux-gnu-11.2.1
  • Windows 11 Enterprise;
  • Chrome Version 128.0.6613.138 (Official Build) (64-bit);

Files below can be loaded without issues:
Floating Point Issues.zip
Also some smoke checks were passed successfully for Multi-Tailed Arrow: selection, movement of arrow itself, changing of size and position of head, changing positions of top and bottom tails, changing size and positions of added tails, removing of tails, copy/cut paste, undo/redo actions, deletion of Multi-Tailed Arrows

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
…ith fixed precision usage (#5450)

- fixed tails movement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Priority: High
Projects
None yet
3 participants