Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle with monomer number should be few pixels down #5453

Closed
AlexeyGirin opened this issue Sep 9, 2024 · 1 comment · Fixed by #5460 or #5487
Closed

Circle with monomer number should be few pixels down #5453

AlexeyGirin opened this issue Sep 9, 2024 · 1 comment · Fixed by #5460 or #5487
Assignees
@rrodionov91
Labels
bug Customer Feedback Flex mode Bucket: Flex canvas related mode Priority: High
Milestone
Ketcher 2.25.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Toggle to Macro - Sequence mode
  2. Load from file: Circle with monomer number should be few pixels down.zip

Actual behavior
image
Note that circle with monomer number even overlap monomer alias

Expected behavior
Place circle in the center between monomer border and alias
image

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Reference issues: #4554
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.25.0-rc.2 milestone Sep 9, 2024
@rrodionov91 rrodionov91 self-assigned this Sep 9, 2024
rrodionov91 added a commit that referenced this issue Sep 9, 2024
@rrodionov91
#5453 - Circle with monomer number should be few pixels down
d8d6072
This was linked to pull requests Sep 9, 2024
#5453 - Circle with monomer number should be few pixels down #5458
Closed
#5453 - Circle with monomer number should be few pixels down #5460
Merged
rrodionov91 added a commit that referenced this issue Sep 9, 2024
@rrodionov91
#5453 - Circle with monomer number should be few pixels down
559d8ad
@rrodionov91 rrodionov91 linked a pull request Sep 9, 2024 that will close this issue
#5425 - Undo-Redo operations over ambiguous monomer causes broken canvas #5461
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 9, 2024
@rrodionov91
#5453 - Circle with monomer number should be few pixels down (#5461)
38f94d1
rrodionov91 added a commit that referenced this issue Sep 10, 2024
@rrodionov91
#5453 - Circle with monomer number should be few pixels down (#5460)
8db84b2
@rrodionov91 rrodionov91 removed a link to a pull request Sep 10, 2024
#5425 - Undo-Redo operations over ambiguous monomer causes broken canvas #5461
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 10, 2024
@rrodionov91
#5453 - Circle with monomer number should be few pixels down
76705e6
rrodionov91 added a commit that referenced this issue Sep 11, 2024
@rrodionov91
#5453 - Circle with monomer number should be few pixels down (#5485)
cb78446
rrodionov91 added a commit that referenced this issue Sep 11, 2024
@rrodionov91
#5453 - Circle with monomer number should be few pixels down
d17b9a6
@rrodionov91 rrodionov91 linked a pull request Sep 11, 2024 that will close this issue
Backmerge: #5453 - Circle with monomer number should be few pixels down #5487
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 11, 2024
@rrodionov91
Backmerge: #5453 - Circle with monomer number should be few pixels do…
3b075c5 
…wn (#5487)
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image
Versions

  • Ketcher Version 2.25.0-rc.2 Build at 2024-09-14; 10:47:47
  • Indigo Toolkit Version 1.24.0-rc.2.0-g5f2751d70-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.138 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#5453 - Circle with monomer number should be few pixels down (#5485)
6963aee
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5453 - Circle with monomer number should be few pixels do…
f15a59e 
…wn (#5487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Customer Feedback Flex mode Bucket: Flex canvas related mode Priority: High
Projects
None yet
Milestone
Ketcher 2.25.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin