Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micro structures connected to polymer chains are not shown on Sequence mode canvas #5673

Closed
AlexeyGirin opened this issue Oct 7, 2024 · 1 comment · Fixed by #5821 or #5828
Closed

Micro structures connected to polymer chains are not shown on Sequence mode canvas #5673

AlexeyGirin opened this issue Oct 7, 2024 · 1 comment · Fixed by #5821 or #5828
Assignees
@rrodionov91
Labels
bug Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Priority: High Sequence mode Bucket: Sequence mode related issues User's Feedback
Milestone
Ketcher 2.26.0-rc.4

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 7, 2024 •
edited by Zhirnoff
Loading

Steps to Reproduce

  1. Go to Molecules mode
  2. Load from file: Micro structures connected to polymer chains are not shown on Sequence mode canvas.zip
  3. Switch to Macro mode - Sequence

Actual behavior
Micro structure is missing
image

Expected behavior
Micro structure is present (micro structures as CHEMS should be represented as @)
image

Versions

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Toolkit Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)
  • Win10

Issue found while testing: #5359

#188442045
@AlexeyGirin AlexeyGirin added bug Priority: High Sequence mode Bucket: Sequence mode related issues Micro-Macro Bucket: Bugs related to Micro structures on Macro mode labels Oct 7, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.27.0-rc.1 milestone Oct 7, 2024
@rrodionov91 rrodionov91 self-assigned this Oct 18, 2024
rrodionov91 added a commit that referenced this issue Oct 18, 2024
@rrodionov91
#5673 - Micro structures connected to polymer chains are not shown on…
dd12b46 
… Sequence mode canvas
@rrodionov91 rrodionov91 linked a pull request Oct 18, 2024 that will close this issue
#5673 - Micro structures connected to polymer chains are not shown on Sequence mode canvas #5821
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 21, 2024
@rrodionov91
#5673 - Micro structures connected to polymer chains are not shown on…
9346812 
… Sequence mode canvas (#5821)
rrodionov91 added a commit that referenced this issue Oct 21, 2024
@rrodionov91
#5673 - Micro structures connected to polymer chains are not shown on…
74420fa 
… Sequence mode canvas (#5821)
@rrodionov91 rrodionov91 linked a pull request Oct 21, 2024 that will close this issue
Backmerge: #5673 - Micro structures connected to polymer chains are not shown on Sequence mode canvas #5828
Merged
9 tasks
mnmsvlw pushed a commit that referenced this issue Oct 21, 2024
@rrodionov91 @mnmsvlw
#5673 - Micro structures connected to polymer chains are not shown on…
c46ef6c 
… Sequence mode canvas (#5821)
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.26.0-rc.4 Build at 2024-10-18; 17:00:39
  • Indigo Toolkit Version 1.25.0-rc.3.0-g795119115-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.59 (Official Build) (64-bit)
  • Win10

rrodionov91 added a commit that referenced this issue Oct 22, 2024
@rrodionov91
#5673 - Micro structures connected to polymer chains are not shown on…
a753e58 
… Sequence mode canvas (#5821) (#5828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Priority: High Sequence mode Bucket: Sequence mode related issues User's Feedback
Projects
None yet
Milestone
Ketcher 2.26.0-rc.4
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff