Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to establish connection between micro structure and macro ones #5679

Closed
AlexeyGirin opened this issue Oct 8, 2024 · 1 comment · Fixed by #5757, #5766, #5847 or #5871
Closed

Unable to establish connection between micro structure and macro ones #5679

AlexeyGirin opened this issue Oct 8, 2024 · 1 comment · Fixed by #5757, #5766, #5847 or #5871
Assignees
@rrodionov91
Labels
Flex mode Bucket: Flex canvas related mode Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Priority: High
Milestone
Ketcher 2.26.0-rc.6

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 8, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Molecules mode
  2. Put Benzene ring on the canvas
  3. Switch to Macro mode - Flex
  4. Put peptide on the canvas
  5. Try establish connection between peptide and any atom of ring

Actual behavior
It doesn't work

Unable.to.establish.connection.between.micro.structure.and.macro.ones.mp4

Expected behavior
It works

Versions

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Toolkit Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)
  • Win10

Issue found while testing: #5359
@AlexeyGirin AlexeyGirin added bug Priority: High Micro-Macro Bucket: Bugs related to Micro structures on Macro mode labels Oct 8, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.26.0-rc.2 milestone Oct 8, 2024
@AlexeyGirin AlexeyGirin added the Flex mode Bucket: Flex canvas related mode label Oct 8, 2024
@rrodionov91 rrodionov91 self-assigned this Oct 14, 2024
rrodionov91 added a commit that referenced this issue Oct 14, 2024
@rrodionov91
#5679 - Unable to establish connection between micro structure and ma…
46eb1b0 
…cro ones
@rrodionov91 rrodionov91 linked a pull request Oct 14, 2024 that will close this issue
#5679 - Unable to establish connection between micro structure and macro ones #5757
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 15, 2024
@rrodionov91
#5679 - Unable to establish connection between micro structure and ma…
54bc78f 
…cro ones (#5757)
rrodionov91 added a commit that referenced this issue Oct 15, 2024
@rrodionov91
#5679 - Unable to establish connection between micro structure and ma…
2145907 
…cro ones (#5757)
@rrodionov91 rrodionov91 linked a pull request Oct 15, 2024 that will close this issue
Backmerge: #5679 - Unable to establish connection between micro structure and macro ones #5766
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 16, 2024
@rrodionov91
#5679 - Unable to establish connection between micro structure and ma…
5a90831 
…cro ones (#5757) (#5766)
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

Versions

  • Ketcher Version 2.26.0-rc.3 Build at 2024-10-16; 14:35:25
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#5679 - Unable to establish connection between micro structure and ma…
75416b5 
…cro ones (#5757) (#5766)
@rrodionov91 rrodionov91 reopened this Oct 23, 2024
rrodionov91 added a commit that referenced this issue Oct 23, 2024
@rrodionov91
#5679 - Unable to establish connection between micro structure and ma…
1520a61 
…cro ones
@rrodionov91 rrodionov91 linked a pull request Oct 23, 2024 that will close this issue
#5679 - Unable to establish connection between micro structure and macro ones #5847
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 24, 2024
@rrodionov91
#5679 - Unable to establish connection between micro structure and ma…
c08edfa 
…cro ones (#5847)
rrodionov91 added a commit that referenced this issue Oct 25, 2024
@rrodionov91
#5679 - Unable to establish connection between micro structure and ma…
6591956 
…cro ones (#5847)
@rrodionov91 rrodionov91 linked a pull request Oct 25, 2024 that will close this issue
Backmerge: #5848 - Unable to establish connection between micro structure and sugar or phopshate (and partially - unresolved monomer) #5871
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 25, 2024
@rrodionov91
Backmerge: #5848 - Unable to establish connection between micro struc…
d6ddc42 
…ture and sugar or phopshate (and partially - unresolved monomer) (#5871)

* #5679 - Unable to establish connection between micro structure and macro ones (#5847)
* #5848 - Unable to establish connection between micro structure and sugar or phopshate (and partially - unresolved monomer) (#5866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Flex mode Bucket: Flex canvas related mode Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Priority: High
Projects
None yet
Milestone
Ketcher 2.26.0-rc.6
2 participants
@rrodionov91 @AlexeyGirin