Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After bulk deletion of monomer abbreviations, Undo returns expanded monomers #5699

Closed
Zhirnoff opened this issue Oct 8, 2024 · 1 comment · Fixed by #5867 or #5872
Closed

After bulk deletion of monomer abbreviations, Undo returns expanded monomers #5699

Zhirnoff opened this issue Oct 8, 2024 · 1 comment · Fixed by #5867 or #5872
Assignees
@svvald
Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Priority: High
Milestone
Ketcher 2.26.0-rc.7

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Oct 8, 2024 •
edited
Loading

Steps to Reproduce

  1. Open file in Macro mode (Flex mode) monomers-cycled.zip
  2. Switch to Micro mode
  3. Select all structure by Rectangle tool and press Erase
  4. Press Undo

Actual behavior
After bulk deletion of monomer abbreviations not all highlighted abbreviations deleted and Undo returns expanded monomers

Expected behavior
After bulk deletion of monomer abbreviations all highlighted abbreviations deleted and Undo returns deleted abbreviations on the same positions

Videos

2024-10-08_16h23_36.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.1]
Indigo version
[Version 1.25.0-rc.1]
Bug found during testing: #5400
@Zhirnoff Zhirnoff added bug Priority: High Macro-Micro Bucket: Macro-Micro View related issues labels Oct 8, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.26.0-rc.2 milestone Oct 8, 2024
svvald added a commit that referenced this issue Oct 24, 2024
@svvald
#5699 – Fix collapsed monomers and their bonds bulk selection, remova…
71fa3d0 
…l and undoing in micro mode
svvald added a commit that referenced this issue Oct 25, 2024
@svvald
#5699 – Fix collapsed monomers and their bonds bulk selection, remova…
e964e21 
…l and undoing in micro mode (#5867)
@svvald svvald linked a pull request Oct 25, 2024 that will close this issue
#5699 – Fix collapsed monomers and their bonds bulk selection, removal and undoing in micro mode #5867
Merged
9 tasks
svvald added a commit that referenced this issue Oct 25, 2024
@svvald
Backmerge: #5699 – Fix collapsed monomers and their bonds bulk select…
b3f60ed 
…ion, removal and undoing in micro mode (#5867)
@svvald svvald linked a pull request Oct 25, 2024 that will close this issue
Backmerge: #5699 – Fix collapsed monomers and their bonds bulk selection, removal and undoing in micro mode #5872
Merged
9 tasks
svvald added a commit that referenced this issue Oct 28, 2024
@svvald
Backmerge: #5699 – Fix collapsed monomers and their bonds bulk select…
d0956ee 
…ion, removal and undoing in micro mode (#5867) (#5872)
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Nov 4, 2024

Tested. Bug fixed.

2024-11-04_16h42_59.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.7]
Indigo version
[Version 1.25.0-rc.4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svvald svvald

Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Priority: High
Projects
None yet
Milestone
Ketcher 2.26.0-rc.7
4 participants
@svvald @rrodionov91 @AlexeyGirin @Zhirnoff