Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The application doesn't work after "Undo" #615

Closed
AleksandrPokrovskii opened this issue Jul 8, 2021 · 2 comments · Fixed by #642
Closed

The application doesn't work after "Undo" #615

AleksandrPokrovskii opened this issue Jul 8, 2021 · 2 comments · Fixed by #642
Assignees
@AndreiMazol @nseufulina
Labels
Priority: High
Milestone
Release 2.3.0

Comments

@AleksandrPokrovskii
Copy link
Contributor

Steps to Reproduce

  1. Launch Ketcher
  2. Add chain on the canvas
  3. Add chain from the following atom
    image
  4. Click "Undo"

Expected behavior
Everything is working correctly.

Actual behavior
"Undo" works incorrect. The application does not respond to actions.
@AleksandrPokrovskii AleksandrPokrovskii added this to the Release 2.3.0 milestone Jul 8, 2021
@AndreiMazol AndreiMazol reopened this Jul 9, 2021
@AleksandrPokrovskii
Copy link
Contributor Author

If you change the priority of operations to the next.

  • CalcImplicitH priority - 2
  • BondAttr priority - 4
  • BondDelete priority - 4
  • AtomDelete priority - 5

Steps to Reproduce:

  1. Launch Ketcher
  2. Create a benzene molecule using the Templates tool.
  3. Add chain
    image
  4. select part of chain
  5. Click "Rotate tool"
  6. Rotate selected part of chain to merge with benzene molecule
    image
  7. Click "Undo/Redo" several times

Expected behavior
Everything is working correctly.

Actual behavior
Undo, redo after chain merge works correctly.
TypeError: Cannot read property 'begin' of undefined after flip single up bond.
TypeError: Cannot read property 'pp' of undefined after merging structure with rotation tool.

AndreiMazol added a commit that referenced this issue Jul 15, 2021
@AndreiMazol
#615 undo fromitemsfuse action does not work properly (#642)
a35ebe1 
* update priority of operations

* update priority of AtomMove operation
@AndreiMazol AndreiMazol linked a pull request Jul 15, 2021 that will close this issue
#615 undo fromitemsfuse action does not work properly #642
Merged
@nseufulina
Copy link

Release/2.3 The issue is closed as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiMazol AndreiMazol

@nseufulina nseufulina

Labels
Priority: High
Projects
None yet
Milestone
Release 2.3.0
Development

Successfully merging a pull request may close this issue.

#615 undo fromitemsfuse action does not work properly epam/ketcher
3 participants
@AndreiMazol @AleksandrPokrovskii @nseufulina