Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1044 Text Tool: Add special symbols #1048

Merged
merged 10 commits into from
Dec 9, 2021

Conversation

r1z3rISGOD
Copy link
Contributor

No description provided.

@r1z3rISGOD r1z3rISGOD marked this pull request as draft December 1, 2021 09:52
Kirill Kapytov added 3 commits December 1, 2021 13:12
…ols' into #1044-Text-Tool-Add-special-symbols

# Conflicts:
#	packages/ketcher-react/src/icons/index.tsx
@ElenaOdnoshivkina ElenaOdnoshivkina marked this pull request as ready for review December 1, 2021 15:16
@ElenaOdnoshivkina ElenaOdnoshivkina linked an issue Dec 1, 2021 that may be closed by this pull request
@@ -111,6 +111,7 @@ import UndoIcon from './files/undo.svg'
import ZoomInIcon from './files/zoom-in.svg'
import ZoomOutIcon from './files/zoom-out.svg'
import FunctionalGroupsIcon from './files/functional-groups.svg'
import Symbols from './files/symbols.svg'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow naming convention

@import '../../../../../../../style/variables';
@import '../../../../../../../style/mixins';

.textButton {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to re-use styles, as styles in TextButton.module.less are basically identical

@ElenaOdnoshivkina ElenaOdnoshivkina marked this pull request as draft December 6, 2021 15:20
@ElenaOdnoshivkina ElenaOdnoshivkina marked this pull request as ready for review December 7, 2021 07:15
@AndreiMazol AndreiMazol merged commit 203aad9 into master Dec 9, 2021
@AndreiMazol AndreiMazol deleted the #1044-Text-Tool-Add-special-symbols branch December 9, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Tool: Add special symbols
4 participants