Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1292 Incorrect horizontal scrollbars in save structure modal window #1296

Merged
merged 4 commits into from
Mar 3, 2022
Merged

#1292 Incorrect horizontal scrollbars in save structure modal window #1296

merged 4 commits into from
Mar 3, 2022

Conversation

AnaMoskvina
Copy link
Contributor

  • get rid of redundant scrollbars
  • apply unified font for textarea
  • add rule for scrollbars for mozilla

Anastasiia Moskvina added 2 commits March 2, 2022 11:55
@AnaMoskvina AnaMoskvina linked an issue Mar 2, 2022 that may be closed by this pull request
Incorrect horizontal scrollbars in Save Structure modal window #1292
Closed
karen-sarkisyan
karen-sarkisyan suggested changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@karen-sarkisyan karen-sarkisyan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that besides preventing overflows maybe let's also fix style of a horizontal scrollbar, in case it happens to appear somewhere?

We only need to set its height (same as width when it's vertical) in mixins.less:

  &::-webkit-scrollbar {
    width: 4px;
+   height: 4px;
    background-color: @color-scroll-inactive;
    border-radius: 2px;
    -webkit-border-radius: 2px;
  }

So horizontal scrollbars would be thin too:
image

@AndreiMazol AndreiMazol merged commit 4255ecd into master Mar 3, 2022
@AndreiMazol AndreiMazol deleted the #1292-incorrect-horizontal-scrollbars-in-save-structure-modal-window branch March 3, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreiMazol AndreiMazol AndreiMazol approved these changes

@karen-sarkisyan karen-sarkisyan karen-sarkisyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect horizontal scrollbars in Save Structure modal window
3 participants
@AnaMoskvina @karen-sarkisyan @AndreiMazol