#1801 Refactor standalone struct service. Get rid of unnecessary Indigo-worker creation. #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitvex
force-pushed
the
#1801-worker-speed-up
branch
from
b3a4c86 to
03925b2
Compare
evgeniiFrolov1
requested changes
Nov 3, 2022
| const message: OutputMessage<string> = e.data | ||
| if (message.type !== undefined) { | ||
| const event = messageTypeToEventMapping[message.type] | ||
| console.log(`emitted event ${event}`) |
There was a problem hiding this comment.
Could you remove console.log pls?
There was a problem hiding this comment.
Okay, I thought that was intentional.
| @@ -460,7 +490,10 @@ class IndigoService implements StructService { | |||
| data: commandData | |||
| } | |||
|
|
|||
| worker.postMessage(inputMessage) | |||
| this.EE.removeListener('calculateCip', action) | |||
There was a problem hiding this comment.
What do you think about replacing string literal with enum
for example :
this.EE.removeListener(ListenerType.CalculateCip, action)There was a problem hiding this comment.
Good proposal :) Will do
evgeniiFrolov1
changed the title
evgeniiFrolov1
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.