#2142 s groups that combine multiple molecules get lost when saving as ket file #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitvex
approved these changes
Feb 15, 2023
Nitvex
deleted the
#2142-s-groups-that-combine-multiple-molecules-get-lost-when-saving-as-ket-file
branch
Nitvex
added a commit
that referenced
this pull request
Feb 15, 2023
…en saving as ket file (#2219) * Revert "#2142: s groups get lost when saving as ket file (#2191)" This reverts commit 2892953. * Fix S-Groups which combines multiple molecules getting lost when saving as ket file * #2142 – updated indigo version to 1.10.0-rc.3 --------- Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
Nitvex
added a commit
that referenced
this pull request
Feb 15, 2023
…en saving as ket file (#2219) (#2225) * Revert "#2142: s groups get lost when saving as ket file (#2191)" This reverts commit 2892953. * Fix S-Groups which combines multiple molecules getting lost when saving as ket file * #2142 – updated indigo version to 1.10.0-rc.3 --------- Co-authored-by: Yulei Chen <yulei_chen@epam.com>
ansivgit
pushed a commit
that referenced
this pull request
Feb 22, 2023
…en saving as ket file (#2219) (#2225) * Revert "#2142: s groups get lost when saving as ket file (#2191)" This reverts commit 2892953. * Fix S-Groups which combines multiple molecules getting lost when saving as ket file * #2142 – updated indigo version to 1.10.0-rc.3 --------- Co-authored-by: Yulei Chen <yulei_chen@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2142
This PR includes two commits.
The first commit is to revert the previous merged commit which resolved the issue in another way.
The second commit is implemented as the proposed solution written in the issue description.