#2216 S-Group pop-up tool tip is positioned so that it overlaps structure #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate structure calculation do not change at all.
For now it calculates according to the green rectangle that appears when user hovering over the element.
Function calculateMiddleCoordsForRect calculate middle coord for each side of the rect.
After that panel appears relativly to the middle point of side.
- created WrapperPositionedRelativeToRectangle component.
- moved calculateScrollOffsetX , calculateScrollOffsetY into helpers.ts to reduce code duplication
- created calculateMiddleCoordsForRect accepts array of arrays [[1,2], [3,4], [3,4]] => [{ x: 2, y: 3 }, { x: 3, y: 4}]
- added wrapperRef on div to get dinamically changed width / height of the element
Konstantin1996
changed the title
| (line) => line.slice(1) | ||
| ) | ||
|
|
||
| const [mLeftSide, mBottomSide, mRightSide, mTopSide] = |
There was a problem hiding this comment.
What does the 'm' prefix mean in variable names? :)
| const viewportRightLimit = | ||
| render?.clientArea?.clientWidth - BAR_PANEL_SIZE - width | ||
|
|
||
| // We need to remove first element of the path. Example of the path => ['M', 23, 43] |
There was a problem hiding this comment.
Just curious, why do we need to remove it? Looks like we are just picking it?
KonstantinEpam23
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done?
For now it calculates according to the green rectangle that appears when user hovering over the element. Function calculateMiddleCoordsForRect calculate middle coord for each side of the rect. After that panel appears relativly to the middle point of side.
Panel info is always in the bottom if it is center of the page.
Close to borders
Please, review and add to the q