#2267- Using Template Tool, Salts and Solvents should replace Atoms, Functional Groups, and Salts and Solvents & #1994 - Salts and Solvents: Edit notification appears instead of replacing new Salt or Solvent #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleicul
changed the title
| if (mergeItems?.atoms.size === 1 && mergeItems.bonds.size === 0) { | ||
| // get ID of single dst (target) atom we are hovering over | ||
| return { map: 'atoms', id: mergeItems.atoms.values().next().value } | ||
| } | ||
| return null | ||
| return undefined |
There was a problem hiding this comment.
@yuleicul can you please explain this change
There was a problem hiding this comment.
The return value of getDragCtxItem is assigned to this.dragCtx.item whose type is DragContextItem | undefined.
Before this PR, the type of this.dragCtx.item was like DragContextItem | undefined | null. I wanted to simplify undefined | null as undefined or null. Because we have code like delete this.dragCtx.item, undefined is a better solution.
|
Since lots of conflicts, see the new PR #2504 without refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2267
Closes #1994
Refactors
TemplateTool: extracts code for specific function to method, adds types to member variables.