#2213 Data S-Group: 'Field value' text when placed on a structure becomes hard to access #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed a link to an issue
AnastasiiaPlyako
approved these changes
Apr 28, 2023
gairon
reviewed
May 8, 2023
| @@ -454,22 +454,29 @@ function findClosestItem(restruct, pos, maps, skip, scale) { | |||
| // eslint-disable-line max-params | |||
There was a problem hiding this comment.
I found the same function in in Core - packages/ketcher-core/src/application/editor/shared/closest.js:415
Do we need to update this one also?
There was a problem hiding this comment.
Couldn't find the usage of findClosestItem. Looks like we can remove this function from Core. Or at least mark it deprecated and for deletion.
There was a problem hiding this comment.
Added a separate task for this: #2638
KonstantinEpam23
deleted the
#2213-data-s-group-field-value-text-when-placed-on-a-structure-becomes-hard-to-access
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added high priority for S-Group data when we make actions with elements (hover/click).