#2276 Click & drag an 'Atom' on FG, Salts and Solvents, FG connected with Atom forms many atoms #2577
Conversation
There was a problem hiding this comment.
Hi @VasilevDO , it looks really cool to me in the sense that the bond-adding action will be reverted after hovering back! 👍
Unfortunately, I found a small problem which seems not to behave correctly, according to
Expected behavior
...
For Salt and Solvents: Atom appears where the left mouse button was released without a connection
...
| if (dragCtx.item.id === ci.id) { | ||
| if ( | ||
| ci.map === 'functionalGroups' && | ||
| FunctionalGroup.isContractedFunctionalGroup(ci.id, functionalGroups) |
There was a problem hiding this comment.
that's fun that I have the same logic in my PR :) I think we need to extract this into a separate function and reuse it.
https://github.com/epam/ketcher/pull/2580/files#diff-ee62e3d2a7eb8e9230e2d13e3cfe44e4ea9ea805a61f971355d38aab66dda856R62
|
|
||
| const ciFunctionalGroupName = | ||
| ci?.map === 'functionalGroups' | ||
| ? molecule.functionalGroups.get(ci?.id)?.name |
There was a problem hiding this comment.
could we write here "ci?.map === 'functionalGroups' && molecule.functionalGroups.get(ci?.id)?.name"?
|
Just a kind reminder, next time please remember to click 're-request review' after your code is ready again 😃
|
Closes #2276
Changes: