#2765 - Introduce to .ket file specification attachment point information for super atoms #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion for super atoms
yuleicul
reviewed
Jul 14, 2023
| @@ -18,6 +18,7 @@ import { Atom, Bond, SGroup, Struct } from 'domain/entities'; | |||
|
|
|||
| import { Elements } from 'domain/constants'; | |||
| import { ifDef } from 'utilities'; | |||
| import { SGroupAttachmentPoint } from 'domain/entities/sGroupAttachmentPoint'; | |||
There was a problem hiding this comment.
For clean imports, maybe we can:
// domain/entities/index.ts
export * from './sGroupAttachmentPoint';// moleculeToStruct.ts
import { Atom, Bond, SGroup, Struct, SGroupAttachmentPoint } from 'domain/entities';
yuleicul
approved these changes
Jul 17, 2023
…tion for super atoms
Nitvex
changed the title
…int_information_for_super_atoms' of https://github.com/epam/ketcher into #2765-introduce_to_ket_file_specification_attachment_point_information_for_super_atoms
Nitvex
deleted the
#2765-introduce_to_ket_file_specification_attachment_point_information_for_super_atoms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #2765
How the feature works? / How did you fix the issue?
.ketfile with sgroup attachment points.ketfile with sgroup attachment pointsin the PR also updated the internal model name for the sgrouAttachmentPoint
additionalData>>attachmentIdto have better alignment with ket format specification (/packages/ketcher-core/src/domain/serializers/ket/schema.json)Check list
#1234 – issue name