#2078 center molecules after layout #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter-molecules-after-layout-and-pasting
Nitvex
requested review from
AleksandraSmolianinova,
Ustianskii,
Vehemen and
Zhirnoff
as code owners
rrodionov91
changed the title
rrodionov91
reviewed
Jul 18, 2023
Comment on lines
15
to
18
| export function recoordinate(editor: Editor, rp?: Vec2 /* , vp */) { | ||
| // rp is a point in scaled coordinates, which will be positioned | ||
| // vp is the point where the reference point should now be (in view coordinates) | ||
| // or the center if not set |
There was a problem hiding this comment.
Looks like "vp" argument is not used here. We can remove it and related comment
Nitvex
force-pushed
the
2078-center-molecules-after-layout-and-pasting
branch
from
dc00b86
to
8f65ff7
Compare
rrodionov91
approved these changes
Jul 18, 2023
AleksandraSmolianinova
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
closes #2078
Check list
#1234 – issue name