Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3230 - Support parsing KET file for macromolecules on ketcher side #3292

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Sep 12, 2023

Closes #3230
Closes #3231

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91 rrodionov91 linked an issue Sep 12, 2023 that may be closed by this pull request
@rrodionov91 rrodionov91 force-pushed the 2370-erase-tool branch 2 times, most recently from 0716c44 to 19b56df Compare September 13, 2023 10:59
Base automatically changed from 2370-erase-tool to master September 13, 2023 11:42
@rrodionov91 rrodionov91 force-pushed the 3230-ket-parsing-macromolecules branch from 594f1b5 to d6b4f58 Compare September 13, 2023 13:58
@rrodionov91 rrodionov91 force-pushed the 3230-ket-parsing-macromolecules branch from 1df9b41 to ff01c78 Compare September 15, 2023 11:51
@SashaGraves SashaGraves self-requested a review September 15, 2023 11:59
- added ket macromolecules deserializer for monomers and bonds
- changed entities coordinate system to angstrems
…n ketcher side

- added ket macromolecules serializer for monomers and bonds
@rrodionov91 rrodionov91 force-pushed the 3230-ket-parsing-macromolecules branch from ff01c78 to 71dcb67 Compare September 15, 2023 12:34
@rrodionov91 rrodionov91 merged commit e62b0b8 into master Sep 18, 2023
@rrodionov91 rrodionov91 deleted the 3230-ket-parsing-macromolecules branch September 18, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants