#3339 - Add empty options for atom charges and isotops #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix failed tests
MartaWilliams
approved these changes
Oct 4, 2023
nanoblit
reviewed
Oct 4, 2023
packages/ketcher-core/src/application/render/restruct/reatom.ts
Outdated
Show resolved
Hide resolved
- Fix pr comment
AKZhuk
force-pushed
the
3339-add-empty-options-for-atom-charges-and-isotops
branch
from
2254d63
to
10caeff
Compare
nanoblit
approved these changes
Oct 4, 2023
Nitvex
reviewed
Oct 4, 2023
| if (value === '0') return ''; | ||
| return value.includes('-') ? value : `+${value}`; | ||
| if (value === '') return value; | ||
| const regExpResult = /^([+-]?)([0-9]{1,3}|1000)([+-]?)$/.exec(value); |
There was a problem hiding this comment.
Could you, please, clarify/add comment, when there is a case with +number+? What is it applicable for?
There was a problem hiding this comment.
For charge input ketcher supports +/- before and after number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name