Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro: #3539 – When pull bond away from monomer and press 'Escape', bond remains on canvas #3556

Conversation

ivan-arkhipov-epam
Copy link
Collaborator

@ivan-arkhipov-epam ivan-arkhipov-epam commented Nov 9, 2023

How the feature works? / How did you fix the issue?

Can't provide a screenshot, but basically the new behavior is: when a user presses Escape while drawing a bond, the bond is removed (which wasn't happening before).

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@ivan-arkhipov-epam ivan-arkhipov-epam changed the title Correct handling escape key when drawing a bond #3539-macro-when-pull-bond-away-from-monomer-and-press-escape-bond-remains-on-canvas Nov 9, 2023
@ivan-arkhipov-epam ivan-arkhipov-epam changed the title #3539-macro-when-pull-bond-away-from-monomer-and-press-escape-bond-remains-on-canvas #3539 Macro: When pull bond away from monomer and press 'Escape', bond remains on canvas Nov 9, 2023
@ivan-arkhipov-epam ivan-arkhipov-epam marked this pull request as ready for review November 9, 2023 09:42
@Nitvex Nitvex changed the title #3539 Macro: When pull bond away from monomer and press 'Escape', bond remains on canvas Macro: #3539 – When pull bond away from monomer and press 'Escape', bond remains on canvas Nov 9, 2023
@rrodionov91 rrodionov91 merged commit 7150de2 into master Nov 9, 2023
5 checks passed
@rrodionov91 rrodionov91 deleted the 3539-macro-when-pull-bond-away-from-monomer-and-press-escape-bond-remains-on-canvas branch November 9, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro: When pull bond away from monomer and press 'Escape', bond remains on canvas
3 participants