Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3544 – option to disable custom query feature #3592

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

Nitvex
Copy link
Collaborator

@Nitvex Nitvex commented Nov 20, 2023

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

closes #3544

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@Nitvex Nitvex force-pushed the 3544-option-to-disable-custom-query-feature branch from 6f12b29 to e4bca69 Compare November 20, 2023 13:51
@Nitvex Nitvex marked this pull request as ready for review November 20, 2023 14:21
localStorage.getItem(KETCHER_SAVED_OPTIONS_KEY) || '{}',
);
} catch (e) {
KetcherLogger.error('optionsManager.ts::OptionsManager::getOptions', e);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to change message here to SettingsManager.ts:...

@Nitvex Nitvex force-pushed the 3544-option-to-disable-custom-query-feature branch from e4bca69 to fc10667 Compare November 20, 2023 14:38
@Nitvex Nitvex merged commit a6800a2 into master Nov 20, 2023
5 checks passed
@Nitvex Nitvex deleted the 3544-option-to-disable-custom-query-feature branch November 20, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable "Custom Query" feature
2 participants