Autotests: #3454 - peptide monomer library #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peptide-monomer-library
…totests-peptide-monomer-library
auto-assign
bot
requested review from
chgayane,
Nitvex and
urszula-gawlowska
chgayane
approved these changes
Dec 12, 2023
| test('add molecule in favourites', async ({ page }) => { | ||
| // favourites check. there is a bug - favourite sign (star) is golden when hovered(should be dark grey) | ||
| // https://github.com/epam/ketcher/issues/3477 | ||
| // await page.waitForSelector('.star'); |
There was a problem hiding this comment.
Why this line is commented out? If it's not needed then remove this, please, and if it should be uncommented after fixing bug then it should be described at comment.
Nitvex
reviewed
Dec 13, 2023
| options?: { masks?: Locator[]; maxDiffPixelRatio?: number }, | ||
| ) { | ||
| const maxTimeout = 3000; | ||
| const editor = page.locator('[class*="MuiBox-root"]'); |
There was a problem hiding this comment.
Let's add a testId for this.
Nitvex
reviewed
Dec 13, 2023
| options?: { masks?: Locator[]; maxDiffPixelRatio?: number }, | ||
| ) { | ||
| const maxTimeout = 3000; | ||
| const editor = page.locator('[class*="shown monomer-library"]'); |
There was a problem hiding this comment.
I propose to create a more generic function for taking screenshots of specific element. We already have a bunch of functions which do the same job and the only difference is – test id
…totests-peptide-monomer-library
urszula-gawlowska
approved these changes
Dec 18, 2023
- update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name