Macro: #3713 - Hot keys for toolbar buttons are not implemented in Macromoleculas view #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implemented toolbar btn highlighting
auto-assign
bot
requested review from
Nitvex,
StarlaStarla and
urszula-gawlowska
…acromolecules # Conflicts: # packages/ketcher-polymer-editor-react/src/Editor.tsx
Nitvex
approved these changes
Jan 5, 2024
| const hotKeys = initHotKeys(keySettings); | ||
| const shortcutKey = keyNorm.lookup(hotKeys, event); | ||
|
|
||
| if (keySettings[shortcutKey] && keySettings[shortcutKey].handler) { |
There was a problem hiding this comment.
We can simplify
if (keySettings[shortcutKey]?.handler)
|
|
||
| setupHotKeysEvents() { | ||
| this.hotKeyEventHandler = (event) => this.handleHotKeyEvents(event); | ||
| document.addEventListener('keydown', this.hotKeyEventHandler); |
There was a problem hiding this comment.
Can we just simply?
setupHotKeysEvents() {
document.addEventListener('keydown', this. handleHotKeyEvents);
}
There was a problem hiding this comment.
Nope, because we need to bind 'this' to hotKeyEventHandler method. And this.hotKeyEventHandler.bind(this) also didn't work because it returns another function and it did not clear event listener in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name