Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4008 design implementation is different from the reference design #4060

Merged
merged 3 commits into from
Feb 12, 2024
Merged

4008 design implementation is different from the reference design #4060

merged 3 commits into from
Feb 12, 2024

Conversation

captain2b
Copy link
Collaborator

@captain2b captain2b commented Feb 8, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

Fix styles
Fix presentation with embedded pdf

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@captain2b captain2b linked an issue Feb 8, 2024 that may be closed by this pull request
Design implementation is different from the reference design #4008
Closed
@captain2b captain2b changed the base branch from master to release/2.18 February 8, 2024 13:15
@captain2b captain2b marked this pull request as ready for review February 8, 2024 14:21
@captain2b captain2b force-pushed the 4008-design-implementation-is-different-from-the-reference-design branch from efedeaf to f9b4bbf Compare February 12, 2024 11:04
@captain2b captain2b force-pushed the 4008-design-implementation-is-different-from-the-reference-design branch from bc3253f to 0518cf6 Compare February 12, 2024 12:28
@captain2b captain2b merged commit 04bb580 into release/2.18 Feb 12, 2024
3 checks passed
@captain2b captain2b deleted the 4008-design-implementation-is-different-from-the-reference-design branch February 12, 2024 12:57
@captain2b captain2b mentioned this pull request Feb 12, 2024
Merged
@rrodionov91 rrodionov91 linked an issue Feb 13, 2024 that may be closed by this pull request
System can't open file with few reactions #4066
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrodionov91 rrodionov91 rrodionov91 approved these changes

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@captain2b captain2b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System can't open file with few reactions Design implementation is different from the reference design
2 participants
@captain2b @rrodionov91