#3648 - Macro: Displaying unmodified nucleotide chains in sequence representation #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fied-sequence # Conflicts: # packages/ketcher-core/src/application/render/renderers/RenderersManager.ts # packages/ketcher-core/src/domain/entities/BaseMonomer.ts # packages/ketcher-core/src/domain/entities/DrawingEntitiesManager.ts # packages/ketcher-core/src/domain/entities/Phosphate.ts # packages/ketcher-core/src/domain/entities/Sugar.ts # packages/ketcher-react/src/components/Icon/utils/iconNameToIcon.ts
- fixed clear canvas in sequence mode
auto-assign
bot
requested review from
ilya-asiyuk-epam,
StarlaStarla and
Zhirnoff
This was
linked to
issues
Feb 16, 2024
…fied-sequence # Conflicts: # packages/ketcher-core/src/domain/serializers/ket/ketSerializer.ts
Zhirnoff
approved these changes
Feb 19, 2024
| const command = super.initialize(); | ||
| const editor = CoreEditor.provideEditorInstance(); | ||
|
|
||
| editor.drawingEntitiesManager.applyFlexLayoutMode(); |
There was a problem hiding this comment.
seems these 2 lines of code will be executed twice since they are also included in reArrangeChains func.
|
|
||
| currentChainStartPosition = new Vec2( | ||
| currentChainStartPosition.x, | ||
| currentChainStartPosition.y + 75 + 47 * Math.floor(chain.length / 31), |
There was a problem hiding this comment.
Do we need to extract CONSTs for these numbers?
| .attr('stroke', 'black') | ||
| .attr('x1', secondMonomerX + 6) | ||
| .attr('x2', secondMonomerX + 6) | ||
| .attr('y1', mainLineY2 + 5) |
There was a problem hiding this comment.
Do we need to extract constants for these numbers?
| this.firstNodeInChainPosition.x + | ||
| indexInRow * 18 + | ||
| Math.floor(indexInRow / this.nthSeparationInRow) * 10, | ||
| this.firstNodeInChainPosition.y + 47 * rowIndex, |
There was a problem hiding this comment.
Do we need to extract constants for these numbers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name