Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #4241 - Pasting large cyclodextrins structure cause Ketcher to freeze #4265

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Mar 18, 2024

  • added debounce for structures merge calculations
  • added stop handling of mousemove if previous handler in progress
  • added functionalGroup link to sgroup to more efficiently search it during different operations (for example for checking is atom in contracted group)

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

- added debounce for structures merge calculations
- added functionalGroup link to sgroup to more efficiently search it during different operations (for example for checking is atom in contracted group)
@rrodionov91 rrodionov91 changed the title #4241 - Pasting large cyclodextrins structure cause Ketcher to freeze Backmerge: #4241 - Pasting large cyclodextrins structure cause Ketcher to freeze Mar 19, 2024
@rrodionov91 rrodionov91 merged commit 21372b2 into master Mar 19, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 4241-paste-structures-freeze-molecules-mode branch March 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting large cyclodextrins structure cause Ketcher to freeze
3 participants