Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4144 - Connection of bond to atom inside s-group supergroup cause it connected incorrectly in terms of layout #4367

Merged
merged 7 commits into from
Apr 1, 2024
Merged

#4144 - Connection of bond to atom inside s-group supergroup cause it connected incorrectly in terms of layout #4367

merged 7 commits into from
Apr 1, 2024

Conversation

baranovdv
Copy link
Contributor

@baranovdv baranovdv commented Mar 28, 2024 •
edited
Loading

  • add findAttachmentPoints function
  • add addAttachmentPoint function
  • add removeAttachmentPoint function

How the feature works?

2024-03-28.23.31.50.mov

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@baranovdv
#4144 - Connection of bond to atom inside s-group supergroup cause it…
481d89c 
… connected incorrectly in terms of layout

- add findAttachmentPoints function
@baranovdv baranovdv linked an issue Mar 28, 2024 that may be closed by this pull request
Connection of bond to atom inside s-group supergroup cause it connected incorrectly in terms of layout #4144
Open
@NataliaLoginova NataliaLoginova merged commit 8f23da6 into master Apr 1, 2024
5 checks passed
@NataliaLoginova NataliaLoginova deleted the 4144-connection-of-bond-to-atom-inside-s-group-supergroup-cause-it-connected-incorrectly-in-terms-of-layout branch April 1, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-asiyuk-epam ilya-asiyuk-epam ilya-asiyuk-epam approved these changes

@NataliaLoginova NataliaLoginova NataliaLoginova approved these changes

@rrodionov91 rrodionov91 Awaiting requested review from rrodionov91

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@baranovdv baranovdv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection of bond to atom inside s-group supergroup cause it connected incorrectly in terms of layout
3 participants
@baranovdv @NataliaLoginova @ilya-asiyuk-epam