Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3986 - Macro: Selected RNA preset not discards when mouse moved on c… #4372

Merged
merged 2 commits into from
Apr 1, 2024
Merged

#3986 - Macro: Selected RNA preset not discards when mouse moved on c… #4372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5025a80
#3986 - Macro: Selected RNA preset not discards when mouse moved on c…
Mar 29, 2024
3f340f0
update test snapshot
Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ketcher-autotests/tests/Macromolecule-editor/Peptides/peptide-monomer-library.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ test.describe('Peptide library testing', () => {
/*
Test case: Actions with structures https://github.com/epam/ketcher/issues/3986
Description: Selected RNA discards when mouse hovered on canvas and ESC button is clicked.
The test is currently not functioning correctly as the bug has not been fixed
*/
await page.getByTestId('RNA-TAB').click();
await page.getByTestId('C_C_R_P').click();
Expand Down
Binary file modified ...cards--3d4ed-e-hovered-on-canvas-and-ESC-button-is-clicked-2-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions packages/ketcher-core/src/application/editor/tools/RnaPreset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,16 @@ class RnaPresetTool implements Tool {
this.phosphatePreviewRenderer?.show(this.editor.theme);
}
}

hidePreview() {
this.rnaBasePreviewRenderer?.remove();
this.phosphatePreviewRenderer?.remove();
this.sugarPreviewRenderer?.remove();
}

destroy(): void {
this.hidePreview();
}
}

export { RnaPresetTool };
Loading