Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backmerge: #4369 - Del button works as Backspace button that is wrong #4469

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Backmerge: #4369 - Del button works as Backspace button that is wrong #4469

merged 1 commit into from
Apr 16, 2024

Conversation

burcinkarimov
Copy link
Collaborator

@burcinkarimov burcinkarimov commented Apr 16, 2024 •
edited by NataliaLoginova
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@NataliaLoginova NataliaLoginova linked an issue Apr 16, 2024 that may be closed by this pull request
Macro: Del button works as Backspace button that is wrong #4369
Closed
@NataliaLoginova NataliaLoginova added this to the Ketcher 2.20.0-rc.3 milestone Apr 16, 2024
@NataliaLoginova NataliaLoginova merged commit bf6d26c into release/2.21 Apr 16, 2024
3 checks passed
@NataliaLoginova NataliaLoginova deleted the 4369-del-button-works-as-backspace-button-that-is-wrong branch April 16, 2024 12:28
@AlexeyGirin AlexeyGirin removed this from the Ketcher 2.20.0-rc.3 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaLoginova NataliaLoginova NataliaLoginova approved these changes

@rrodionov91 rrodionov91 Awaiting requested review from rrodionov91

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@burcinkarimov burcinkarimov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro: Del button works as Backspace button that is wrong
3 participants
@burcinkarimov @NataliaLoginova @AlexeyGirin