Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autotests: #4287 - Verification of Micro-Macro switching #4577

Merged
merged 17 commits into from
May 13, 2024
Merged

Autotests: #4287 - Verification of Micro-Macro switching #4577

merged 17 commits into from
May 13, 2024

Conversation

Zhirnoff
Copy link
Collaborator

@Zhirnoff Zhirnoff commented May 6, 2024 •
edited
Loading

  • added tests to 'macro-micro-switcher';
  • added expected snapshots

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@Zhirnoff
- added tests to 'macro-micro-switcher';
3725bf3 
- added expected snapshots
@Zhirnoff Zhirnoff self-assigned this May 6, 2024
@Zhirnoff Zhirnoff linked an issue May 6, 2024 that may be closed by this pull request
Autotests: Verification of Micro-Macro switching #4287
Closed
@Zhirnoff Zhirnoff changed the title Autotests: #4287 - Sequence representation Autotests: #4287 - Verification of Micro-Macro switching May 6, 2024
AlexeyGirin
AlexeyGirin approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@AlexeyGirin AlexeyGirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Zhirnoff added 15 commits May 7, 2024 12:54
@Zhirnoff
- added tests;
031c96e 
- added 1 test file;
- added expected snapshots
@Zhirnoff
Merge branch 'master' of https://github.com/epam/ketcher into 4287-au…
2a4f198 
…totests-verification-of-micro-macro-switching
@Zhirnoff
- added tests;
7d73867 
- added expected snapshots
@Zhirnoff
Merge branch 'master' of https://github.com/epam/ketcher into 4287-au…
772c139 
…totests-verification-of-micro-macro-switching
@Zhirnoff
- added tests;
fbabb06 
- added 2 test files;
- added expected snapshots
@Zhirnoff
Merge branch 'master' of https://github.com/epam/ketcher into 4287-au…
ee87d41 
…totests-verification-of-micro-macro-switching
@Zhirnoff
Merge branch 'master' of https://github.com/epam/ketcher into 4287-au…
84869bf 
…totests-verification-of-micro-macro-switching
@Zhirnoff
- added tests;
8fdbc3d 
- added expected snapshots
@Zhirnoff
Merge branch 'master' of https://github.com/epam/ketcher into 4287-au…
38890c0 
…totests-verification-of-micro-macro-switching
@Zhirnoff
Merge branch 'master' of https://github.com/epam/ketcher into 4287-au…
613682e 
…totests-verification-of-micro-macro-switching
@Zhirnoff
Merge branch 'master' of https://github.com/epam/ketcher into 4287-au…
f7f7869 
…totests-verification-of-micro-macro-switching
@Zhirnoff
Merge branch 'master' of https://github.com/epam/ketcher into 4287-au…
c37772d 
…totests-verification-of-micro-macro-switching
@Zhirnoff
- added tests;
7f73103 
- added expected snapshots
@Zhirnoff
- added 'maxDiffPixelRatio' to 1 test
64b7ea4
@Zhirnoff
Merge branch 'master' of https://github.com/epam/ketcher into 4287-au…
951a293 
…totests-verification-of-micro-macro-switching
AlexeyGirin
AlexeyGirin approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@AlexeyGirin AlexeyGirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Zhirnoff Zhirnoff merged commit 0e2a56b into master May 13, 2024
5 checks passed
@Zhirnoff Zhirnoff deleted the 4287-autotests-verification-of-micro-macro-switching branch May 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyGirin AlexeyGirin AlexeyGirin approved these changes

@rrodionov91 rrodionov91 Awaiting requested review from rrodionov91

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

Assignees

@Zhirnoff Zhirnoff

Labels
Autotests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autotests: Verification of Micro-Macro switching
2 participants
@Zhirnoff @AlexeyGirin