Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3816 - Added validations and monomer Item disablement #4597

Merged
merged 17 commits into from
May 31, 2024
Merged

#3816 - Added validations and monomer Item disablement #4597

merged 17 commits into from
May 31, 2024

Conversation

vitaepam
Copy link
Contributor

@vitaepam vitaepam commented May 9, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

Closes #3816

  • Added into RNA Accordion validation for Bases, Sugars and Phosphates if they can't be added to New RNA preset they will be disabled;
  • Added validation of RNA which is taken from already existing presets (maybe added from file or library), if it's not align with validation - Error will be shown;
  • Updated validation for 'Add to Presets' button, now it's active only if two monomers selected;
  • Updated README file for autotests;
  • Changed in Playwright tests 12ddR Sugar to 25R because 12ddR does not have R3 connection and could not be added into RNA;

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • reviewers are notified about the pull request

@vitaepam vitaepam force-pushed the 3816-macro-rna-builder-allows-creating-an-invalid-preset-with-disconnected-sugar branch from b25fff7 to 1e40095 Compare May 27, 2024 14:43
@vitaepam vitaepam force-pushed the 3816-macro-rna-builder-allows-creating-an-invalid-preset-with-disconnected-sugar branch from 657c3dc to b330438 Compare May 30, 2024 15:06
@ilya-asiyuk-epam ilya-asiyuk-epam merged commit f4704bc into master May 31, 2024
5 checks passed
@ilya-asiyuk-epam ilya-asiyuk-epam deleted the 3816-macro-rna-builder-allows-creating-an-invalid-preset-with-disconnected-sugar branch May 31, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-asiyuk-epam ilya-asiyuk-epam ilya-asiyuk-epam approved these changes

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

Assignees

@vitaepam vitaepam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro: RNA Builder allows creating an invalid preset with disconnected sugar
2 participants
@vitaepam @ilya-asiyuk-epam