#4509 - In the Text-editing mode, when inserting a fragment after pressing Ctrl+V twice, the cursor is moved to another row #4664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
AlexeyGirin,
ilya-asiyuk-epam and
StarlaStarla
svvald
reviewed
May 29, 2024
packages/ketcher-core/src/application/editor/modes/SequenceMode.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-core/src/application/editor/modes/SequenceMode.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-core/src/application/editor/modes/SequenceMode.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-core/src/application/editor/modes/SequenceMode.ts
Outdated
Show resolved
Hide resolved
svvald
approved these changes
May 29, 2024
NataliaLoginova
approved these changes
May 29, 2024
Guch1g0v
deleted the
4509-macro-in-the-text-editing-mode-when-inserting-a-fragment-after-pressing-ctrl+v-twice-the-cursor-is-moved-to-another-row
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses the issue where, in Text-editing mode, the cursor moves to another row after inserting a fragment by pressing Ctrl+V twice.
Solution
The problem has been resolved by implementing a check for the presence of phosphate in the current sequence and the inserted sequence.
Testing
Manual testing has been performed to validate the fix in various scenarios within the Text-editing mode.
Impact
This fix improves the user experience by preventing the cursor from inadvertently moving to another row after inserting a fragment. It enhances the overall usability and reliability of the Text-editing mode.
References
In the Text-editing mode, when inserting a fragment after pressing Ctrl+V twice, the cursor is moved to another row #4509
Check list
#1234 – issue name