#4880 – Adjust previews – add APs, show IDT aliases for previews in sequence mode, increase debounce time #5160
Conversation
auto-assign
bot
requested review from
AlexeyGirin,
NataliaLoginova and
rrodionov91
svvald
force-pushed
the
4880-change-previews-for-hovering-over-the-monomer-in-the-library-and-on-the-canvas
branch
from
0b75a75
to
4e44f14
Compare
ketcher-autotests/tests/test-data/KET/chem-connected-to-micro-structure-expected.ket
Outdated
Show resolved
Hide resolved
packages/ketcher-macromolecules/src/components/monomerLibrary/RnaPresetGroup/RnaPresetGroup.tsx
Outdated
Show resolved
Hide resolved
packages/ketcher-macromolecules/src/hooks/useAttachmentPoints.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-macromolecules/src/state/common/editorSlice.ts
Outdated
Show resolved
Hide resolved
| return null; | ||
| } | ||
|
|
||
| if (presetName.includes('MOE')) { |
There was a problem hiding this comment.
Why rules applied only for MOE? I believe it should be for all presets
There was a problem hiding this comment.
There is the following requirement for these specific presets:
All the other presets should just have their base both on canvas and in the library. I don't like handling it by name though, maybe we could handle it in a better manner later
| const { R1, R2 } = attachmentPointsToBonds; | ||
| // Handle phosphate exclusively | ||
| if (base === 'Phos') { | ||
| if (R1 !== null && R1.firstMonomer instanceof Sugar) { |
There was a problem hiding this comment.
Sugar can be the second monomer in bond if user connected it from right to left. Probably need another check here
There was a problem hiding this comment.
According to the requirement, we need to check only the specific case when sugar and phosphate have left-to-right connection.
4.2.3. If the phosphate is the last monomer in the chain, but the second to last is not a sugar/nucleozide, the alias should be: 3Phos.
It doesn't matter, if there is a sugar after phosphate, it will be covered by the general rules for monomers
packages/ketcher-macromolecules/src/hooks/useIDTAliasesTextForMonomer.ts
Outdated
Show resolved
Hide resolved
svvald
force-pushed
the
4880-change-previews-for-hovering-over-the-monomer-in-the-library-and-on-the-canvas
branch
2 times, most recently
from
0073965
to
91f462e
Compare
rrodionov91
force-pushed
the
4880-change-previews-for-hovering-over-the-monomer-in-the-library-and-on-the-canvas
branch
from
ae4fd6a
to
f38b868
Compare
…equence mode, increase debounce time
This reverts commit f2608b3.
- resolved conflicts during rebase
rrodionov91
force-pushed
the
4880-change-previews-for-hovering-over-the-monomer-in-the-library-and-on-the-canvas
branch
from
f38b868
to
42826a9
Compare
rrodionov91
deleted the
4880-change-previews-for-hovering-over-the-monomer-in-the-library-and-on-the-canvas
branch
…equence mode, increase debounce time (#5160) - added changes according new requirements for IDT aliases - added util function to add H to O leaving group - fixed idt aliases in preview for unresolved monomers - updated screenshots --------- Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name