4981 support for ssr #5183
Merged
4981 support for ssr #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 22, 2024 16:34
Closed
rrodionov91
approved these changes
Aug 1, 2024
Guch1g0v
pushed a commit
that referenced
this pull request
Oct 17, 2024
- example-ssr created - example-ssr window error fix & hydration fix --------- Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Raphaeljs uses a reference to window on the top level, so the conditional import was added.
example-ssr with basic nextjs.
Fix for circular import for Icon in ketcher-react.
Some top level window cheks for ketcher-react package.
Check list
#1234 – issue name