#4554 - Support variant monomers in Ketcher (flex mode) #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrodionov91
force-pushed
the
4554-variant-monomers-flex-mode
branch
from
f0c324b to
90c15a1
Compare
- added variant monomers to model/view and deserialization
- temporary skipped tests
rrodionov91
force-pushed
the
4554-variant-monomers-flex-mode
branch
from
501a583 to
5887048
Compare
svvald
approved these changes
Aug 21, 2024
| templateId: string; | ||
| } | ||
|
|
||
| export interface IKetGroupNode { | ||
| type: 'group'; | ||
| export interface IKetVariantMonomerNode { |
There was a problem hiding this comment.
I guess it would be nice to have some common interface to encapsulate id, position and other common fields and IKetMonomerNode and IKetVariantMonomerNode to extend them with a particular type
| @@ -160,7 +191,11 @@ export interface IKetMacromoleculesContentRootProperty { | |||
| } | |||
|
|
|||
| export interface IKetMacromoleculesContentOtherProperties { | |||
| [key: string]: KetNode | IKetMonomerTemplate | IKetMonomerGroupTemplate; | |||
| [key: string]: | |||
There was a problem hiding this comment.
Nitpicking, but { [key: string]: something } might be replaced with Record<string, _something>
| @@ -23,7 +25,7 @@ export class Sugar extends BaseMonomer { | |||
| } | |||
|
|
|||
| private getValidPoint( | |||
| otherMonomer: BaseMonomer, | |||
| otherMonomer: BaseMonomer & IVariantMonomer, | |||
There was a problem hiding this comment.
This types intersection is used here and other files few times, maybe it makes sense to separate it into some util type?
| return _monomer; | ||
| } | ||
|
|
||
| const monomer = new VariantMonomer(variantMonomerItem, position); |
There was a problem hiding this comment.
Maybe it's worth having some method to create variant monomer without changes in model which I implemented recently? Look for createMonomer method within this class
Guch1g0v
pushed a commit
that referenced
this pull request
Oct 17, 2024
- added variant monomers to model/view and serialization/deserialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Check list
#1234 – issue name