Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backmerge: Only bonds highlighting created when select bonds + atoms together #5758

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Backmerge: Only bonds highlighting created when select bonds + atoms together #5758

merged 1 commit into from
Oct 16, 2024

Conversation

aproskurnov
Copy link
Contributor

@aproskurnov aproskurnov commented Oct 14, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

When select bonds + atoms together and create highlight, highlight create now for both: bonds and atoms

Screenshot 2024-10-14 at 20 12 51 Screenshot 2024-10-14 at 20 13 34

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@aproskurnov aproskurnov linked an issue Oct 14, 2024 that may be closed by this pull request
Only bonds is highlighted when the whole molecule with atoms is choosen #5668
Closed
@NataliaLoginova NataliaLoginova changed the title Only bonds highlighting created when select bonds + atoms together Backmerge: Only bonds highlighting created when select bonds + atoms together Oct 16, 2024
@NataliaLoginova NataliaLoginova merged commit 2f6f5e0 into master Oct 16, 2024
5 checks passed
@NataliaLoginova NataliaLoginova deleted the 5668-only-bonds-highlighted-from-selection branch October 16, 2024 06:49
aproskurnov added a commit that referenced this pull request Oct 16, 2024
@aproskurnov
fixed only bonds highlighting (#5758)
c24986a 
Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
aproskurnov added a commit that referenced this pull request Oct 16, 2024
@aproskurnov
fixed only bonds highlighting (#5758)
148d3e0 
Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
Guch1g0v pushed a commit that referenced this pull request Oct 17, 2024
@aproskurnov @Guch1g0v
fixed only bonds highlighting (#5758)
f1c4620 
Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
NataliaLoginova pushed a commit that referenced this pull request Oct 18, 2024
@aproskurnov
#5758 Highlight only bonds when selected bonds + atoms (#5772)
9d6fdec 
* fixed only bonds highlighting (#5758)

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>

* made autotest more stable

---------

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
mnmsvlw pushed a commit that referenced this pull request Oct 21, 2024
@aproskurnov @mnmsvlw
#5758 Highlight only bonds when selected bonds + atoms (#5772)
14ae7a0 
* fixed only bonds highlighting (#5758)

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>

* made autotest more stable

---------

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaLoginova NataliaLoginova NataliaLoginova approved these changes

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

@rrodionov91 rrodionov91 Awaiting requested review from rrodionov91

Assignees

@aproskurnov aproskurnov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only bonds is highlighted when the whole molecule with atoms is choosen
2 participants
@aproskurnov @NataliaLoginova