Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the crash while displaying volumetric data #420

Merged

Conversation

paulsmirnov
Copy link
Member

Description

Fixes #417

Revert (inadvertent?) changes to UberMaterial added in ba59b11 (#342, #344).
We can introduce some of them back after thorough consideration.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation / The changes do not need docs update.

added in ba59b11 (#342, #344).
We can introduce some of them back after thorough consideration.

Fixes #417
@paulsmirnov
Copy link
Member Author

CI check failed due to outdated dependencies. However, no dependencies were changed in this PR. The issue should be addressed separately, not as a part of this fix.

@paulsmirnov paulsmirnov merged commit eb19106 into master Sep 11, 2022
@paulsmirnov paulsmirnov deleted the 417-opening-mrc-file-cause-world2colormatrix-error branch September 11, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening mrc file cause world2colorMatrix error when running on local pc
1 participant