Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access the top window in a safe manner #550

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

paulsmirnov
Copy link
Member

Description

Resolves #524

Fixes Uncaught DOMException: Failed to read a named property 'addEventListener' from 'Window': Blocked a frame with origin "xxx" from accessing a cross-origin frame.

Type of changes

  • Bug fix (non-breaking change that fixes an issue)

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • I have added tests that prove my fix/feature works.
  • The changes do not require updated docs.

Fixes Uncaught DOMException: Failed to read a named property
'addEventListener' from 'Window': Blocked a frame with origin
"xxx" from accessing a cross-origin frame.
@paulsmirnov paulsmirnov self-assigned this Aug 20, 2024
@paulsmirnov paulsmirnov merged commit fa60029 into main Aug 20, 2024
4 checks passed
@paulsmirnov paulsmirnov deleted the 524-viewer-fails-inside-iframe branch August 20, 2024 01:31
@themoenen themoenen mentioned this pull request Sep 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewer fails to initialize inside cross-origin iframe
2 participants