Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy to 1.18 #1

Closed
wants to merge 3 commits into from

Conversation

arjunsavel
Copy link

Description

Bumping Numpy from 1.16 to 1.18. Branched from Ezequiel's PR (tardis-sn#1266) — so merge his first!

Note: Numpy 1.19 breaks on Azure

Motivation and Context

Bumping Numpy to 1.18 offers a host of benefits, including an updated random interface. This would in turn allow for cleaner and faster numba_montecarlo implementations.

How Has This Been Tested?

All Azure tests seem to pass...but more testing is probably warranted.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

epassaro pushed a commit that referenced this pull request Nov 17, 2020
Updating my Version of Tardis and Fixing Environment
@epassaro epassaro closed this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants